Free Clipboard Master 5.65/11/2024 Now that we can override value() in MemoryEntry things are a bit simpler. Functionally this would behave like localizedLabel. This function can then be selectively overridden in Entries that need to localize the value. To replace it we'll need a `virtual QString value(Language language = Language::System)` which by default simply returns the string member. Instead we'll need a virtual function here:Įntry's member `value` needs to become a private m_value for starters. That complicates things beyond what we can achieve by passing the KLS around. We not only need the KLocalizedString to be evaluated "later" but also the KFormat substitution. Upon further inspection I don't think a constructor will do. Yeah, I think this issue is actually a bit ballooned up in scope by design mistakes I've made. I am not really experienced in this field, so hopefully you can help me out a bit here Harald. So maybe some better way of only using one String can be found. I think that actually lead to inconsistencies between this English clipboard version and a version that would appear on a real English setup. On the other hand, I guess having a separate English Strings for the clipboard that would have to be maintained was also not really nice. Also it makes fixing the original bug much harder, unfortunately. The refactoring seems to have caused a regression that now "Arbeitsspeicher" appears in the English clipboard version. This got removed with įor Memory, this is the corresponding code: In the past that has been achieved by having a variable "englishTextForClipboard". This abstraction unfortunately did not take into consideration that one needs to get the English version of translated values back. In the meantime there has been some refactoring going on. Since the link to cgit is not working anymore, I guess this line was meant:
0 Comments
Leave a Reply. |